fix(sass) add "hoistUseStatements: true" option to ensure '@use sass:math' works #14326
Conversation
mcdmaster
changed the title
mcdmaster
force-pushed
the
fix/sass-division
branch
from
569c952
to
a4af6eb
Compare
|
This has so many problems I don't even know where to start. Please don't open any more PRs without testing them yourself first, it's a massive waste of everybody's time. |
KaelWD
added
the
invalid
|
For sure, freeriders are usually "no testers" whom @KaelWD addresses. But when I tried several times getting out of freeriders' world to resolve an issue which suddenly and unexpectedly came from SASS world and, since then, has made users suffer from its faulty logging behavior, I was blamed. Yes, until then, I spent so many days and hours for the program remediation in coding, testing and configuration all through the days and nights. Eventually, that kind of effort of mine has been marked invalid. Actually, that was a waste of time on my end. Anyway, less testing is NOT a focal point because it is a legitimate assumption and/or constraint for everyone who contributes individually. I wonder why this issue is left unfixed for even years. What prevents its remediation? Do you know what the core problem in this issue is to widely impact on entire projects which adopt Vuetify? That should be a focal point. |
|
While I appreciate the effort you've made to try to fix this, the fact is that it just does not work. As I said in your last PR, even a simple |
Description
Revisit remediation of PR #13704, #13938
Fixes #13694
Fixes Tokyo-Metro-Gov/covid19#6346
Motivation and Context
Make this comply with forthcoming major change in
SASS@2in division formulaMake
sassmodule installed up-to-date so that we can reduce its following effort in every refreshUtilize specific options to take effect on these objectives
How Has This Been Tested?
Build & Jest
Markup:
<!doctype html>
<title>Code coverage report for All files</title> <style type='text/css'> .coverage-summary .sorter { background-image: url(sort-arrow-sprite.png); } </style>All files
Types of changes
Checklist:
masterfor bug fixes and documentation updates,devfor new features and backwards compatible changes andnextfor non-backwards compatible changes).