Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple params and line break support for methods and events #70

Open
wants to merge 2 commits into
base: monorepo
Choose a base branch
from

Conversation

xuzicn
Copy link

@xuzicn xuzicn commented Apr 28, 2019

  1. multiple args support for methods and events like JSDoc does. support arg type and default value

  2. support multiple lines in method and event descriptions

    methods: {
    /**
    * @vuese
    * descprition first row
    * descprition second row
    * @arg argA {Boolean} [false] - argA desc
    * @arg argB {String} [foo] - argB desc
    /
    submit(argA, argB) {
    /
    *
    * some-event to do something
    * @arg argA {Boolean} [false] - argA desc
    * @arg argB {String} [foo] - argB desc
    */
    this.$emit('some-event', argA, argB)
    }
    }

@xuzicn xuzicn changed the title Multiple params Multiple params and line break support for methods and events Apr 28, 2019
@ghost
Copy link

ghost commented Dec 12, 2019

Hi,

It would be awesome to see this go in, when can we expect it?

Thanks.

@chrschae
Copy link

I would also love to see this implemented if possible

Comment on lines +19 to +20
"events": "<table><thead><tr><th>Event Name</th><th>Description</th><th>Parameters</th><th>Type</th><th>Default</th></tr></thead><tbody><tr><td rowspan=1>click</td><td rowspan=1>Triggered when clicked</td><td rowspan=1>test</td><td rowspan=1>Boolean</td><td rowspan=1>false</td></tr></tbody></table>",
"methods": "<table><thead><tr><th>Method</th><th>Description</th><th>Parameters</th><th>Type</th><th>Default</th></tr></thead><tbody><tr><td rowspan=1>clear</td><td rowspan=1>Clear form</td><td rowspan=1>test</td><td rowspan=1>Boolean</td><td rowspan=1>false</td></tr></tbody></table>",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was exactly my suggestion in #128 to convert the markdown tables to its html equivalent to format multi-line comments. This PR should resolve my issue as well. Hopefully the author comes back and accepts this, this is a great PR.

@IWANABETHATGUY
Copy link
Member

could you resolve conflicts, and merge current monorepo branch and pass all test ?

@QuinnBast
Copy link

I'd love to see this get added and would try to resolve the conflicts for the MIA author (ping @xuzicn) but I couldn't get the repo setup locally to contribute anything

@IWANABETHATGUY
Copy link
Member

IWANABETHATGUY commented May 18, 2020

I'd love to see this get added and would try to resolve the conflicts for the MIA author (ping @xuzicn) but I couldn't get the repo setup locally to contribute anything

Recently, i am working on other stuff, after that, i will open another branch finish this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants