fix(compat): ensure functional component is not null in $children
#10982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In compat mode, if a component is functional, it will be
null
in$children
array. This happens because$children
are formed fromproxy
property which is not set for functional components:core/packages/runtime-core/src/component.ts
Lines 740 to 746 in 6a8d548
Inside
setupStatefulComponent
:core/packages/runtime-core/src/component.ts
Line 785 in 6a8d548
The fix is to use
component.ctx
(which is theproxy
's original object) as a fallback when populating$children
. I do realize this is not the same object as the wrapped one but this might be sufficient for migration purposes.