Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): use options module name if options provide runtimeModuleName options #10457

Merged
merged 8 commits into from Mar 6, 2024
Merged

fix(compiler-sfc): use options module name if options provide runtimeModuleName options #10457

merged 8 commits into from Mar 6, 2024

Conversation

Doctor-wu
Copy link
Contributor

close #10454

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.5 kB 34.4 kB 31 kB
vue.global.prod.js 148 kB 53.7 kB 47.9 kB

Usages

Name Size Gzip Brotli
createApp 50.7 kB 19.8 kB 18.1 kB
createSSRApp 54.1 kB 21.1 kB 19.3 kB
defineCustomElement 53 kB 20.6 kB 18.7 kB
overall 64.4 kB 24.8 kB 22.5 kB

@Doctor-wu Doctor-wu requested a review from yyx990803 March 5, 2024 13:35
@Doctor-wu
Copy link
Contributor Author

The e2e one seems like an accident

@Doctor-wu
Copy link
Contributor Author

It appears like a lot of snapshots use single quote

@yyx990803 yyx990803 merged commit e76d743 into vuejs:main Mar 6, 2024
11 checks passed
@Doctor-wu Doctor-wu deleted the fix-compile-script-module-import branch March 6, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard code for runtimeModuleName
2 participants
@Doctor-wu @yyx990803