Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add e2e to show usage of defineOptions #1583

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

elevatebart
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023

⚠️ No Changeset found

Latest commit: 67bc37f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@what-the-diff
Copy link

what-the-diff bot commented Jun 28, 2023

PR Summary

  • Enhanced Testing for Button Component

    • Our development team has added a new test case that will check the 'displayName' for certain components in the file button.test.ts. This will help us ensure that our components display as expected on various parts of our system.
  • Updates to Progress Component

    • Within the file Progress.vue, an event handler for 'click' events has been added. This means that the Progress component will now respond to user interactions more effectively, improving the overall user experience.
    • The 'strokeDashoffset' property, a graphic element of the Progress Component, was also modified. Although subtle, users might notice improved visual aesthetics of the component due to this change.
    • For improved readability and understanding, the developers have also added JSDoc comments, outlining the purpose and usage of the component name and display name.
  • Expansion of Setup Syntax Testing

    • File setup-syntax.test.ts now includes fresh test cases for component options, events, and 'expose'. These additional test cases boost the reliability of our components and ensure that they function as expected when executing certain options or encountering specific events.
    • To adapt to changes made, the test cases for 'events' and 'expose' property have been modified to match the updated snapshot, reinforcing system consistency over time.

@cypress
Copy link

cypress bot commented Jun 28, 2023

Passing run #497 ↗︎

0 57 0 0 Flakiness 0

Details:

restore balance in the force
Project: vue-styleguidist Commit: 67bc37f756
Status: Passed Duration: 03:20 💡
Started: Sep 6, 2023 1:51 PM Ended: Sep 6, 2023 1:54 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@elevatebart elevatebart enabled auto-merge (squash) September 6, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant