Fixing an incorrect error message #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzagozen
requested changes
Jul 5, 2023
Comment on lines
+361
to
+365
| self.logger.error("More than {} ({} configured) NICs or a major version greater than {} ({} detected)".format(max_non_licensed_nics, | ||
| num_nics, | ||
| min_non_licensed_major_release, | ||
| major_release) +\ | ||
| " require distributed VSR which requires a license but no license is found") |
There was a problem hiding this comment.
The recent base image change also upgraded Python to 3.9.2 so we can use f-strings:
Suggested change
| self.logger.error("More than {} ({} configured) NICs or a major version greater than {} ({} detected)".format(max_non_licensed_nics, | |
| num_nics, | |
| min_non_licensed_major_release, | |
| major_release) +\ | |
| " require distributed VSR which requires a license but no license is found") | |
| self.logger.error(f"More than {max_non_licensed_nics} ({num_nics} configured) NICs or a major version greater than {min_non_licensed_major_release} ({major_release} detected) require distributed VSR which requires a license, but no license is found") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error message neglects the fact that it could be the major version number that is the problem