fix: turn off unicorn/no-negated-condition

voxpelli · May 9, 2023 · 7508ae4 · 7508ae4
1 parent 07c8ab0
commit 7508ae4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -101,7 +101,7 @@ Instead of simply extending `@voxpelli` you can extend `@voxpelli/eslint-config/
 * :wrench: [`unicorn/catch-error-name`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/catch-error-name.md) – *changed* – I prefer `err` over `error` as I find `error`to be a far too similar name to the built in `Error` class
 * :mute: [`unicorn/explicit-length-check`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/explicit-length-check.md) – *deactivated* – I don't see an issue with `if (string.length)` instead of `if (string.length !== 0)`
 * :warning: [`unicorn/unicorn/no-await-expression-member`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/unicorn/no-await-expression-member.md) – *changed* – eg. useful in chai tests
-* :warning: [`unicorn/unicorn/no-negated-condition`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/unicorn/no-negated-condition.md) – *changed* – set to `warn` instead of `error`
+* :warning: [`unicorn/unicorn/no-negated-condition`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/unicorn/no-negated-condition.md) – *deactivated* – turned off, there are valid cases for this, so it simply gets noisy
 * :mute: [`unicorn/numeric-separators-style`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/numeric-separators-style.md) – *deactivated* – currently not enough good support for this in engines
 * :warning: [`unicorn/prefer-add-event-listener`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-add-event-listener.md) – *changed* – set to `warn` instead of `error`
 * :warning: [`unicorn/prefer-event-target`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules//prefer-event-target.md) – *changed* – set to `warn` instead of `error`

diff --git a/index.js b/index.js
@@ -82,7 +82,7 @@ module.exports = {
  'unicorn/catch-error-name': ['error', { name: 'err', ignore: ['^cause$'] }],
  'unicorn/explicit-length-check': 'off',
  'unicorn/no-await-expression-member': 'warn',
- 'unicorn/no-negated-condition': 'warn',
+ 'unicorn/no-negated-condition': 'off',
  'unicorn/numeric-separators-style': 'off',
  'unicorn/prefer-add-event-listener': 'warn',
  'unicorn/prefer-event-target': 'warn',