Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecated inspect.getargspec() dependency in torch/modelio.py #547

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

inhuszar
Copy link

Code is not yet tested. Please verify my solution.

@ahoopes
Copy link
Collaborator

ahoopes commented Sep 26, 2023

Thanks @inhuszar. Didn't realize getargspec was deprecated all the way back in python 3.0

The line params.update(kwonlydefaults) looks like it might be a bug/typo, no? params isn't a variable

@inhuszar
Copy link
Author

Good point, @ahoopes ! I originally inserted this line on purpose into the equivalent implementation in the Neurite repository, where params stands as a temporary placeholder for self.config: adalca/neurite@30090b7

Here, it appears by mistake, and params should be replaced by self.config. Please check the documentation of inspect.getfullargspec() to see if this new addition is aligned with the original purpose of store_config_args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants