Computing multi-channel NCC over channels individually #314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #313. Thanks for the review!
While we're here, there are use-cases that weigh one modality more than others (e.g., T1 NCC weighed higher than FA NCC is common in DWI analysis). This is straightforward to add with an optional
weights
arg, but there may be some concerns with mild feature creep. Let me know if I should add it. :)