Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(vscode): auto insertion request early exit on vscode #157

Merged
merged 4 commits into from
May 24, 2024

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Apr 2, 2024

The LanguageServicePlugin needs to register auto insertion trigger characters. @volar/vscode consumes trigger characters to determine whether to send auto insertion requests to the language server. This will avoid unnecessary requests to the language server.

@johnsoncodehk johnsoncodehk marked this pull request as ready for review May 24, 2024 22:11
@johnsoncodehk johnsoncodehk merged commit 07c6b8d into master May 24, 2024
6 checks passed
@johnsoncodehk johnsoncodehk deleted the auto-insert-early-exit branch May 24, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant