Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp-plugins: split subpkgs #50486

Merged
merged 1 commit into from
May 31, 2024
Merged

lsp-plugins: split subpkgs #50486

merged 1 commit into from
May 31, 2024

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented May 23, 2024

Tested by me and @slimjimsoftware

This helps unclutter things. @leahneukirchen can you take a look?

@classabbyamp
Copy link
Member

why is this needed? (how is it currently "cluttered"?)

if you're going to do this, you need to make the main package depend on everything you split out to not break other people's setups

@slimjimsoftware
Copy link
Contributor

@classabbyamp desktop menus (for some desktops) get cluttered with LSP icons, there are numerous reports of this and it appears to be something to do with GNOME not following XDG standards? Anyway a quick google shows up this:

https://www.linuxquestions.org/questions/linux-general-1/my-multimedia-menu-is-full-of-some-audio-related-stuff-any-idea-where-these-came-from-4175721036/

https://www.reddit.com/r/linux4noobs/comments/g40e3a/unwanted_lsp_plugins_showing_up/

I can confirm this happens on plasma 6 too.

Apple Silicon mac support requires just the lv2 set of lsp-plugins to enable audio so rather than install the entire set, we can split into subpackages and also avoid the icon clutter

Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.a static libs should be in the devel pkg

srcpkgs/lsp-plugins/template Outdated Show resolved Hide resolved
@dkwo
Copy link
Contributor Author

dkwo commented May 24, 2024

Typically, one only needs one plugin, not necessarily all of them, as well as icons etc. You can compare the clutter via xls.

If the main package depends on all the splitted ones, then what's the point? I propose an install message, similar to Alpine's one.

The plugins were split up into multiple subpackages [...] Be sure to install ones you were using.

Would this work?

I'm trying to get the devel part correct. Does it look right now?

@classabbyamp
Copy link
Member

classabbyamp commented May 26, 2024

If the main package depends on all the splitted ones, then what's the point?

to not break people's setups. we can't know which plugins people were actually using, so lsp-plugins should be treated like a metapkg

@dkwo
Copy link
Contributor Author

dkwo commented May 27, 2024

Let me know if this is now acceptable, then I'll squash my commits.

@classabbyamp
Copy link
Member

squash it

@dkwo
Copy link
Contributor Author

dkwo commented May 27, 2024 via email

@classabbyamp classabbyamp merged commit 06780f3 into void-linux:master May 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants