Modify the volume helper logic.

[blackpiglet]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
• Updated the corresponding documentation in site/content/docs/main.

[codecov]

Codecov Report

Attention: Patch coverage is 83.53659% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 58.79%. Comparing base (49eab81) to head (a91d2cb).

Files	Patch %	Lines
internal/volumehelper/volume_policy_helper.go	84.78%	11 Missing and 3 partials ⚠️
pkg/backup/item_backupper.go	77.08%	9 Missing and 2 partials ⚠️
pkg/backup/backup.go	92.30%	1 Missing ⚠️
pkg/cmd/util/output/backup_describer.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7794      +/-   ##
==========================================
+ Coverage   58.67%   58.79%   +0.11%     
==========================================
  Files         345      345              
  Lines       28743    28764      +21     
==========================================
+ Hits        16866    16911      +45     
+ Misses      10448    10425      -23     
+ Partials     1429     1428       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shubham-pampattiwar]

Thanks a bunch @blackpiglet Added a few minor comments. In addition to them I think there is one case that we need to cover:

• If a volume has a matching snapshot action and at the same time the user also specifies defaultVolumesToFSBackups: true then the snapshot would be skipped by CSI plugin, we need to modify the logic here I believe:

  velero/pkg/backup/actions/csi/pvc_action.go

  Line 136 in 49eab81

  isFSUploaderUsed, err := podvolume.IsPVCDefaultToFSBackup(

[blackpiglet]

Thanks a bunch @blackpiglet Added a few minor comments. In addition to them I think there is one case that we need to cover:

• If a volume has a matching snapshot action and at the same time the user also specifies defaultVolumesToFSBackups: true then the snapshot would be skipped by CSI plugin, we need to modify the logic here I believe:

  velero/pkg/backup/actions/csi/pvc_action.go

  Line 136 in 49eab81

  isFSUploaderUsed, err := podvolume.IsPVCDefaultToFSBackup(

Thanks. Modified.

[Lyndon-Li]

This means all the BIA plugins should not check backup.Spec.SnapshotVolumes, we may need to add this to release notes so as to advice the 3rd plugins to remove this check, cc @reasonerjt

[shubham-pampattiwar]

@blackpiglet PR looks good, just added one comment on removal of unused function.

[shubham-pampattiwar]

/lgtm