Surface errors when waiting for backupRepository #7762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
waitBackupRepoErrsVerbose
branch
from
46db678
to
067ce0d
Compare
|
Wouldn't |
kaovilai
commented
May 6, 2024
kaovilai
force-pushed
the
waitBackupRepoErrsVerbose
branch
from
067ce0d
to
9b55d40
Compare
|
Removed the conditional check on err to always return err. See unit tests changes for updated error values. |
kaovilai
force-pushed
the
waitBackupRepoErrsVerbose
branch
from
9b55d40
to
5c2592d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7762 +/- ##
==========================================
+ Coverage 58.64% 58.66% +0.02%
==========================================
Files 344 344
Lines 28720 28735 +15
==========================================
+ Hits 16843 16858 +15
- Misses 10447 10448 +1
+ Partials 1430 1429 -1 ☔ View full report in Codecov by Sentry. |
Lyndon-Li
reviewed
May 7, 2024
kaovilai
force-pushed
the
waitBackupRepoErrsVerbose
branch
3 times, most recently
from
770b15e
to
e85d824
Compare
Make errors such as those found in vmware-tanzu#6928 (comment) Makes errors easier to understand than "timed out waiting for the condition" Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
waitBackupRepoErrsVerbose
branch
from
e85d824
to
2c6853b
Compare
mateusoliveira43
approved these changes
May 13, 2024
shubham-pampattiwar
approved these changes
May 14, 2024
sseago
approved these changes
May 16, 2024
Lyndon-Li
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make errors such as those found in #6928 (comment)
Makes errors easier to understand than "timed out waiting for the condition"
Signed-off-by: Tiger Kaovilai [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.