testifylint: enable error-nil rule #7670
Open
+218
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7670 +/- ##
==========================================
- Coverage 58.79% 58.77% -0.03%
==========================================
Files 345 345
Lines 28764 28764
==========================================
- Hits 16911 16905 -6
- Misses 10425 10430 +5
- Partials 1428 1429 +1 ☔ View full report in Codecov by Sentry. |
mmorel-35
force-pushed
the
testifylint/error-nil
branch
2 times, most recently
from
1e221bb
to
56d93d9
Compare
blackpiglet
added
the
kind/changelog-not-required
blackpiglet
requested changes
Apr 15, 2024
mmorel-35
force-pushed
the
testifylint/error-nil
branch
2 times, most recently
from
0b23fdb
to
e1125a0
Compare
Hi @blackpiglet , |
mmorel-35
force-pushed
the
testifylint/error-nil
branch
2 times, most recently
from
f8a2aa6
to
7a9fc3f
Compare
|
@mmorel-35 |
mmorel-35
force-pushed
the
testifylint/error-nil
branch
2 times, most recently
from
2f0950b
to
92200ef
Compare
kaovilai
approved these changes
May 20, 2024
|
@mmorel-35 |
mmorel-35
force-pushed
the
testifylint/error-nil
branch
from
92200ef
to
28e40df
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
testifylint/error-nil
branch
from
28e40df
to
330fe0f
Compare
@blackpiglet, that’s ready 👍! |
blackpiglet
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
testifylint: enable error-nil rule
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.