Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make repository password configurable #7600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muxuelanKK
Copy link

The repository password should be configurable.

@kaovilai
Copy link
Contributor

Note: Currently, Velero creates a secret named velero-repo-credentials in the velero install namespace, containing a default backup repository password. You can update the secret with your own password encoded as base64 prior to the first backup (i.e., FS Backup, data mover) targeting to the backup repository. The value of the key to update is

data:
  repository-password: <custom-password>

It's already configurable today.

If you want to enhance the velero server CLI, consider also adding the option to the velero install command.

@muxuelanKK
Copy link
Author

repository-password

Note: Currently, Velero creates a secret named velero-repo-credentials in the velero install namespace, containing a default backup repository password. You can update the secret with your own password encoded as base64 prior to the first backup (i.e., FS Backup, data mover) targeting to the backup repository. The value of the key to update is

data:
  repository-password: <custom-password>

It's already configurable today.

If you want to enhance the velero server CLI, consider also adding the option to the velero install command.

Now we only can edit the secret after velero deployed already, I alse want to add the option to the velero install command.

@Lyndon-Li
Copy link
Contributor

Just changing the secret doesn't work in many cases. E.g., when some existing repos/BSLs are there, when changing the secret, Velero will use the new password to connect to the repos, however, the repos themselves are still with the old password, so the connection will fail.

Actually, supporting dynamically changing the repo password involves many fundamental changes, as discussed in #5443. Therefore, we will need a sophisticated design to cover all the factors, i.e., repo password changing and unified repo API, password preserve, etc.

@Lyndon-Li Lyndon-Li requested review from Lyndon-Li and removed request for reasonerjt and ywk253100 April 1, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants