Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary support for s390x #7505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pandurangkhandeparker
Copy link

@pandurangkhandeparker pandurangkhandeparker commented Mar 7, 2024

Thank you for contributing to Velero!

Signed-off-by: Pandurang Alias Aradhya Khandeparker [email protected]

Please add a summary of your change

This PR aims to add s390x support to Velero binary.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Pandurang Alias Aradhya Khandeparker <[email protected]>
@reasonerjt
Copy link
Contributor

IMHO, given we don't have resources or bandwidth to verify on zLinux, shall we let this remain downstream?

@rposts
Copy link

rposts commented Mar 15, 2024

@reasonerjt If access to s390x system to run tests is an issue then IBM now has a public program for requesting virtual machines for s390x. A member of the Velero team can put in a request via the following form. When approved and sign-up is complete resources can be set up and delegated as appropriate. https://www.ibm.com/community/z/open-source/virtual-machines-request/

Please let us know what is required for s390x binary verification.

It will be great for s390x to be part of several ecosystem that Velero already supports which includes ppc64le and arm as well.

@kaovilai
Copy link
Contributor

Are we open to unsupported binary release (at your own risk)?

@rposts
Copy link

rposts commented Mar 16, 2024

Are we open to unsupported binary release (at your own risk)?

I think we should try to maintain fidelity with other archs - at a minimum s390x binary should pass associated testcases .

@kaovilai
Copy link
Contributor

at a minimum s390x binary should pass associated testcases

How do you propose velero obtain the infra to test this? Running in github actions emulated would be very slow.

@rposts
Copy link

rposts commented Apr 26, 2024

at a minimum s390x binary should pass associated testcases

How do you propose velero obtain the infra to test this? Running in github actions emulated would be very slow.
@kaovilai - pls see above "..A member of the Velero team can put in a request via the following form. When approved and sign-up is complete resources can be set up and delegated as appropriate. https://www.ibm.com/community/z/open-source/virtual-machines-request/ "

This is a real s390x VM which can be used to run the testcases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants