Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client to retrofit #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add client to retrofit #33

wants to merge 1 commit into from

Conversation

razavioo
Copy link

@razavioo razavioo commented Feb 2, 2021

Fixes bug of not adding the client to retrofit

@vmadalin
Copy link
Owner

vmadalin commented Feb 4, 2021

Hi @razavioo, first of all, thanks for your PR and your contribution. Looks amazing, the only point is to fix the related unit test that is currently failing regarding the build more exactly:

> Task :core:compileDevDebugUnitTestKotlin
e: /home/circleci/kotlin-sample-app/core/src/test/kotlin/com/vmadalin/core/di/NetworkModuleTest.kt: (58, 61): No value passed for parameter 'client'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@razavioo @vmadalin