Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add raylib support #235

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add raylib support #235

wants to merge 4 commits into from

Conversation

mohamedLT
Copy link

No description provided.

@MatejMagat305
Copy link
Contributor

is it only about v fmt -w . ?

@Larpon
Copy link
Contributor

Larpon commented Jan 15, 2023

No it's about application design and how to extend vab without building special case support into the app for every framework available out there. A compile time plugin system would be gold - but maybe runtime plugin support would be okay as well. vab also miss some essential features from the v_sdl4android project.

@JalonSolov
Copy link

... but yes, the failing CI check is because the files need to be formatted with v fmt.

src_path := os.join_path(raylib_path, 'src')
ndk_path := ndk.root()
os.execute('make -C ${src_path} clean')
arch_name := if arch == 'arm64-v8a' {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be more eficient and nicer with mach{...} instead of if ... else if ... else?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would look cleaner with match. The else branch for the match would take care of the following if as well.


// add the compiled raylib libraries for each arch
if is_raylib {
build_cmd << '-L ${lflags}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe initialisation of 'lflags' for raylib would be nice put inside if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants