Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder, ci: fix compilation on macos-arm with cstrict; run macos ci also on arm runner #21408

Merged
merged 12 commits into from May 3, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented May 2, 2024

  • Fixes compilation with -cstrict on macos-13 and macos-arm. This is done by only adding -x none when there would be actual paths that follow it.
    ./v -cg -cstrict -o v cmd/v
  • Adds arm runner to macos wokflow.

@ttytm ttytm changed the title ci: run macos ci also on arm runner builder, ci: fix compilation on macos-arm with cstrict; run macos ci also on arm runner May 2, 2024
@ttytm ttytm marked this pull request as draft May 3, 2024 09:11
@ttytm ttytm marked this pull request as ready for review May 3, 2024 10:01
@ttytm
Copy link
Member Author

ttytm commented May 3, 2024

@spytheman can I let the openssl test be skipped in CI runs when testing with macos > 12?

I couldn't resolve it here by adding the modern openssl path to the library path when running in CI.
Having tested and checked logs, export LIBRARY_PATH="$LIBRARY_PATH:$(brew --cellar)/openssl@3/3.3.0/lib/" should add it, though the test failure will remain the same.

A ref. run containing the error: https://github.com/vlang/v/actions/runs/8937395274/job/24549581427?pr=21408

@spytheman
Copy link
Member

@spytheman can I let the openssl test be skipped in CI runs when testing with macos > 12?

Yes, just skip it for that job.

@spytheman spytheman merged commit 7f7d7a1 into vlang:master May 3, 2024
67 checks passed
@ttytm ttytm deleted the ci/macos-ci-on-arm branch May 3, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants