Added full support for Adafruit DotStar LED Strips. #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind fixing the conflicts? |
|
I'll try to load this back up this week and resolve these. |
IvanGirderboot
force-pushed
the
master
branch
from
d41fcfc
to
9dcc544
Compare
|
OK conflicts have been resolved; I'll give it a test locally once my current print is done to ensure it still works. |
|
I can confirm this works still |
|
Friendly ping! this is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the AdaFruit DotStar LED strips which work really well with the Raspberry Pi.
Using a DotStar strip Requires Python3
Note: I know you're working on complete rewrite at the moment, and I'm happy to contribute DotStar support on the new branch. I think there are several opportunities to streamline things (i.e. not using discrete per-product variables like
dotstar_colorandneopixel_color) in the rewrite to make the code cleaner.