Add SCHEMA_GENERATION_CLASS to settings, Allow NinjaGenerateJsonSchema to be overridden #1047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request allow
NinjaGenerateJsonSchema
to be changed via settingsUsecase
I encounter a problem like #965.
while waiting for bug to be resolved. I have a workaround solution by custom behaviour of
get_defs_ref
inside NinjaGenerateJsonSchemaAllowing
NinjaGenerateJsonSchema
to be changed via settings enable clean solution to do this.(I don't want to do monkey patch)