Adjust reader to use point count rather than storage size in size check #19530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinPrivitera
previously approved these changes
May 17, 2024
| @@ -25,6 +25,7 @@ | |||
| <li>Fixed bug where user supplied legend labels were stored in config and session files wrapped in '()' and comma separated. This prevented the values from being parsed correctly and the '()' and commas appeared as part of the labels.</li> | |||
| <li>The location where custom plugins are written when built against installed version of VisIt was corrected.</li> | |||
| <li>Windows build issues for custom plugins against an installed version of VisIt was fixed.</li> | |||
| <li>Fixed a bug in OpenPMD reader that subvertted its ability to read chunked, as opposed to contiguous datasets.</li> | |||
There was a problem hiding this comment.
Suggested change
| <li>Fixed a bug in OpenPMD reader that subvertted its ability to read chunked, as opposed to contiguous datasets.</li> | |
| <li>Fixed a bug in OpenPMD reader that subverted its ability to read chunked, as opposed to contiguous datasets.</li> |
biagas
requested changes
May 17, 2024
Co-authored-by: Kathleen Biagas <[email protected]>
Co-authored-by: Kathleen Biagas <[email protected]>
Ok, testing now. Also found another couple of places where that bad size logic was being used and corrected it. Thanks for the spelling corrections 💪🏻. |
…av/visit into bug-mcm86-17may24-openpmd-sizeck
Yes...doing too many things at once. My VisIt installs are hosed for the moment. But, I did build the plugin as a custom plugin against 3.3.1 and tested on both our existing openpmd test data and on the user's data. Works for both!. Is that sufficient? |
biagas
approved these changes
May 20, 2024
markcmiller86
added a commit
that referenced
this pull request
May 20, 2024
…ck (#19530) * use logical size for size check * Update src/databases/OpenPMD/OpenPMDClasses/PMDFile.C Co-authored-by: Kathleen Biagas <[email protected]> * Update src/resources/help/en_US/relnotes3.4.2.html Co-authored-by: Kathleen Biagas <[email protected]> * rm unused var * fix size checking logic --------- Co-authored-by: Kathleen Biagas <[email protected]>
markcmiller86
added a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #19514.
This same storage size vs. point count logic occurs in multiple places in the reader and so I fixed it in multiple places. I also encountered cases where
datasetStorageSizewas being set but never used and cases where HDF5 objects were being opened but the coorrespondingH5Xclose()calls were commented out. I uncommented them.Resolves #19529
Type of change
[ ] New feature[ ] Documentation update[ ] OtherHow Has This Been Tested?
I tested as a custom plugin against 3.3.1 and opened both the one test case we have and also the data the user attached to the above ref'd discussion. It all worked.
Reminders:
Checklist:
[ ] I have made corresponding changes to the documentation.[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have confirmed new and existing unit tests pass locally with my changes.[ ] I have added new baselines for any new tests to the repo.