Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed old config-site files #19515

Conversation

lukemurphy147
Copy link
Contributor

Description

Resolves #19487

Type of change

  • Bug fix~~
  • New feature~~
  • Documentation update~~
  • Other~~

How Has This Been Tested?

There's nothing to test here; it's just the same changes as #19507.

Reminders:

  • Please follow the style guidelines of this project.
  • Please perform a self-review of your code before submitting a PR and asking others to review it.
  • Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

  • [ ] I have commented my code where applicable.
  • [ ] I have updated the release notes.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added debugging support to my changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have confirmed new and existing unit tests pass locally with my changes.
  • [ ] I have added new baselines for any new tests to the repo.
  • [ ] I have NOT made any changes to protocol or public interfaces in an RC branch.

@JustinPrivitera JustinPrivitera mentioned this pull request May 15, 2024
4 tasks
@JustinPrivitera JustinPrivitera self-requested a review May 15, 2024 16:34
@JustinPrivitera JustinPrivitera self-assigned this May 15, 2024
Copy link
Member

@JustinPrivitera JustinPrivitera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@lukemurphy147
Copy link
Contributor Author

I just tried to remove my real email from this pull request and replace it with my noreply email, but it looks like I accidentally made the commits a second time with the noreply. Could you please amend/delete the commits that have my real email? (Or is it not that big a deal for just two commits?)

@JustinPrivitera
Copy link
Member

All the commits are just going to get squashed into one commit for the PR so I don't think it's a big deal.

@JustinPrivitera JustinPrivitera merged commit af42e09 into visit-dav:develop May 20, 2024
1 check was pending
@lukemurphy147 lukemurphy147 deleted the 19487-remove-old-config-site-files branch May 21, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove config-site/surface86.cmake
2 participants