Fix duplicate query string params when hashbang is enabled #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwoan
force-pushed
the
fix/duplicate-qs
branch
from
f1cba87
to
5ce2222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
hashbangis enabled,page.start()will re-addlocation.searchparams to the hash. This results in duplicate query params when the page is refreshed.See #525 and #412
Proposed Fix
Add
location.searchparams only when a query string has not been added to the hash.Notes
It was a challenge to test this. I couldn't figure out how to supply a query string to the
iframewindow. I ended up configuring jsdom with a query string and testing againstwindow.location. Please advise if there is a better approach.