Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAG: Evolution Games variant + misc #1545

Merged
merged 7 commits into from
Jun 14, 2024
Merged

VAG: Evolution Games variant + misc #1545

merged 7 commits into from
Jun 14, 2024

Conversation

EdnessP
Copy link
Contributor

@EdnessP EdnessP commented Jun 13, 2024

  • Add Evolution Games VAG variant [Rocket Power: Beach Bandits (PS2)]
  • Add .RSM extension to DSP [Bully: Scholarship Edition (Wii)]
  • Hide/Show SCREAM/XACT bank names if they match the input filename (like with RWS/AWD)
  • Use intended AWD codec enum names

@bnnm
Copy link
Collaborator

bnnm commented Jun 13, 2024

For enums where order matters (map 1:1 to some read int) I recommend adding the expected value: typedef enum { VAG = 0x00, PCM = 0x01, ... }. This makes them less brittle if moved around by mistake, and contrasts with other metas where enums are just helpers, plus you can simplify/remove the comment too.

@EdnessP
Copy link
Contributor Author

EdnessP commented Jun 13, 2024

Done. Also spotted a separate bug in XWB where the stream name wasn't being null terminated on all get_name fail cases, causing garbage to appear in the output stream name on XWBs that just have a valid bank name.

Some rare early XWBs also seem to hang/infinitely loop(?) even on the current public build, but I haven't looked at that yet.
Might also be a false positive, unsure.
Nevermind, it was actually just be taking a reeeeeally long time to parse some XSBs.

@bnnm bnnm merged commit 135e90b into vgmstream:master Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants