WIP: Node WorkerChannel native addon #1394
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Substitute spawning a process with mediasoup for running mediasoup in a thread created by this addon. The communication is now done via message passing rather than using unixsocket, avoiding the kernel networking stack for each and every message passed from Node to C++ and viceversa. Performance gains are enhanced by approximately 8 times. Tested by sending a request from Node to C++ and waiting for the response N times in a loop.
ibc
reviewed
May 9, 2024
.gitignore
Outdated
| ## Node WorkerChannel addon. | ||
| /node/workerChannel/node_modules | ||
| /node/workerChannel/build | ||
| /node/workerChannel/lib |
There was a problem hiding this comment.
Shouldn't we include this lib folder in "files" in main package.json? Or should it be managed by the package.json of the addon folder? What I mean is that:
- We only include JS transpiled files in the mediasoup NPM package and not TS files (AKA
node/srcfolder). - Is the addon properly built if we install mediasoup as a git+ssh dependency in the package.json of whatever app using mediasoup?
There was a problem hiding this comment.
Done and tested. package.json files are properly edited. adding mediasoup as a git+ssh dependency of a 3rd party app has also been tested.
|
|
ibc
reviewed
May 9, 2024
ibc
reviewed
May 9, 2024
ibc
reviewed
May 9, 2024
ibc
reviewed
May 9, 2024
ibc
reviewed
May 9, 2024
ibc
reviewed
May 9, 2024
ibc
reviewed
May 9, 2024
ibc
reviewed
May 9, 2024
|
Please merge v3 and check prettier and eslint path arrays in npm-scripts.mjs |
This reverts commit 4237fc2.
Node will clean the native addon once it garbage collects the corresponding JS instance.
ibc
reviewed
May 20, 2024
assign JS instance of the addon to 'undefined' when closed, to indicate the Node GC that it can be freed. Otherwise the tests won't finish due to the correponsing handles being opened.
Lower npm versions than 10.3.0 fail building the addon. Error: No module named 'distutils'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitute spawning a process with mediasoup for running mediasoup in a thread created by this addon.
The communication is now done via message passing rather than using unixsocket, avoiding the kernel networking stack for each and every message passed from Node to C++ and viceversa.
Performance gains are enhanced by approximately 8 times. Tested by sending a request from Node to C++ and waiting for the response N times in a loop.
Caveats:
TODO: