Separate handling of read and write contract functions #46
Conversation
|
|
||
| constructor(address: string, abi: string, signer: VerifiedWallet | Signer) { | ||
| this.signer = signer; | ||
| this.abiInterface = new utils.Interface(abi) | ||
| this.contract = new ethers.Contract(address, this.abiInterface, signer); | ||
| } | ||
|
|
||
| private isReadFunction(functionName: string, ...args: any): boolean { |
There was a problem hiding this comment.
...args can be removed here
| @@ -34,10 +34,13 @@ | |||
| "@biconomy/account": "^4.1.1", | |||
| "ethereumjs-tx": "^2.1.2", | |||
| "ethers": "^5.7.2", | |||
| "tslib": "^2.6.2" | |||
| "sinon": "^18.0.0", | |||
There was a problem hiding this comment.
i understand sinon is needed for your testcase, we can't add new dependencies to sdk especially the ones we can do without, we need to remove sinon and your testcase now that your it runs without errors. viem has been updated as well to "viem": "^2.12.0" on my recent update
There was a problem hiding this comment.
okay I removed sinon. it works without error.
There was a problem hiding this comment.
nice work with the test you can remove it and edit src/test/readFunctions.spec.ts to add more read functions(doesn't have to base sepolia anymore and you can monitor the console logs to ensure read function didn't call userOp)
There was a problem hiding this comment.
I run tests for other read functions. no errors, it works perfectly fine without calling userOp.
How many read functions to include in the test?
| }, | ||
| "devDependencies": { | ||
| "@types/mocha": "^10.0.6", | ||
| "@types/sinon": "^17.0.3", |
There was a problem hiding this comment.
sinon needs to be removed here too
There was a problem hiding this comment.
Nice work, the test ran as expected too. few changes are required before merging @vishal-k25
This pull request introduces changes by handling the function calls by differentiating between read (view/pure) and write functions.