Differentiated read and write functions for gas less and normal transactions #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohzcrea8me
requested changes
May 22, 2024
There was a problem hiding this comment.
@Swag19602 this is fine if all readFunctions starts with "get" but wouldn't work for read functions that don't start with get for examples Erc20 read functions: name, symbol, decimals, totalSupply e.t.c
Changes:
- use the contract abi to get the state of each function and determine if it's a read or write function
- You can edit the read function testcase from : src/test/readFunctions.spec.ts to include more read functions that does not start with get to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kallolborah can you please review this? And tell me about further steps?