Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix off-by-one bug while reading heaptrack files #8101

Merged
merged 4 commits into from
May 16, 2024
Merged

fix off-by-one bug while reading heaptrack files #8101

merged 4 commits into from
May 16, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented May 7, 2024 •
edited by padmaia

Description

allocations are zero indexed...

Testing Instructions

Closes PACK-3043

@sokra sokra requested a review from a team as a code owner May 7, 2024 14:27
@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 8, 2024 6:31am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 6:31am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 8, 2024 6:31am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 6:31am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 6:31am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 6:31am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 6:31am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 6:31am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 6:31am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 6:31am

@sokra sokra requested a review from arlyon May 7, 2024 14:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024 •
edited

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra enabled auto-merge (squash) May 8, 2024 06:22
@sokra sokra disabled auto-merge May 16, 2024 09:21
@sokra sokra merged commit 4bf2c1e into main May 16, 2024
48 of 50 checks passed
@sokra sokra deleted the sokra/tracing-heaptrack branch May 16, 2024 09:21
@kdy1 kdy1 mentioned this pull request May 17, 2024
Merged
sokra pushed a commit to vercel/next.js that referenced this pull request May 17, 2024
@kdy1 @ForsakenHarmony
Update turbopack & swc_core (#65450)
138e45c 
### What?

* vercel/turbo#8101 <!-- Tobias Koppers - fix
off-by-one bug while reading heaptrack files -->
* vercel/turbo#8130 <!-- Tobias Koppers -
refactor memory tracking -->
* vercel/turbo#8097 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.92.5` -->

Update swc_core.


### Why?

To keep in sync and fix styled-jsx issues

### How?

Closes PACK-3042

---------

Co-authored-by: hrmny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlyon arlyon arlyon approved these changes

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sokra @arlyon