feat(turborepo): pass through arguments only for root tasks #8089
+32
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 7 Ignored Deployments
|
|
@HelloWorld017 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
HelloWorld017
force-pushed
the
fix/wrong-passthrough-args-cache-key
branch
from
11e8bb9
to
05409ce
Compare
|
This would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the document, it says that cli arguments are not passed through task dependencies.
But when I actually run a task with additional arguments (e.g.
turbo run dev -- --env=stage) the arguments (e.g.--env=stage) are passed through all the dependencies, and their caches are missed.Related Issues: #1744 #5743
Fixes
Only pass the additional cli arguments to the root tasks. (= tasks which are not required by other tasks)
Testing Instructions
design-systemexample.turbo run build --summarize -- --disable-telemetry.--disable-telemetryis only passed in@repo/docs#build, not@acme/ui#buildturbo run build --summarize -- --test@acme/ui#buildis cached.