fix(turbopack): Fix edge cases of tree shaking #7986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
|
The test case with added issues is a wrong test case, but I'm not sure what should I do.
export { notCompiled } from "./not-compiled.js";
export { notExisting } from "./not-existing.js";
export { notExecuted } from "./not-executed.js";
export * from "./not-executed.js";
export * from "./a.js";
export * from "./b.js";
export const local = "local";We import export { notCompiled } from "./not-compiled.js";
export { notExisting } from "./not-existing.js";
export { notExecuted } from "./not-executed.js";because we have several So, I want to get this PR merged without it and work on it as a separate PR. This is for two purposes:
Problematic case
export * from "package-star";
export * from "./side-effect.js";
import "./side-effect2.js";
export const outer = "outer";
import { effect } from "./check-side-effect.js";
effect("index.js");We import |
sokra
approved these changes
May 27, 2024
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
May 28, 2024
This includes an update to lightningcss to 1.0.0-alpha.57 vercel/turbo#7986 vercel/turbo#8218 vercel/turbo#8222
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
May 28, 2024
This includes an update to lightningcss to 1.0.0-alpha.57 vercel/turbo#7986 vercel/turbo#8218 vercel/turbo#8222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes PACK-2966
Testing Instructions
I'll add some tests