Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: gradient & support more degree unit #562

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Jackie1210
Copy link
Contributor

@Jackie1210 Jackie1210 commented Oct 15, 2023

I am working on implementing repeating-linear-gradient, but I think we should refactor logic here at first for future.

  • I made a lib css-gradient-parser since vendor we currently use is lack of tests and really hard to read and debug.
  • support turn, rad, grad in linear-gradient

@vercel
Copy link

vercel bot commented Oct 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
satori-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 0:36am

@Jackie1210 Jackie1210 changed the title refactor: gradient && support more degreee unit refactor: gradient & support more degreee unit Oct 15, 2023
@Jackie1210 Jackie1210 changed the title refactor: gradient & support more degreee unit refactor: gradient & support more degree unit Oct 15, 2023
@Jackie1210
Copy link
Contributor Author

Hi,@shuding!Do you have time to have a check on this PR? I have finished the repeating-linear-gradient, which I will make a PR based on this one. Thanks for your time~

@mustafasegf
Copy link

@shuding hi there, I would love to have this feature. Can you please review this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants