You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here I just use inline style just like filter in satori to reduce result size and rely on the powerful resvg. It needs to upgrade @resvg/resvg-js to 2.4.1 to support mix-blend-mode. However, it casues two tests fail which were okay before.
The solution of mix-blend-mode is lazy way because it relies on the browser and resvg implement the specific feature. I have to find a common way to workaround BackgroundImage and BackgroundAlpha in svg so that we can support similar css feature such as backdrop-filter, mix-blend-mode. Let me exp it again 😂
@Jackie1210mix-blend-mode is broken is Safari and BackgroundImage/BackgroundAlpha isn't supported by browsers and most libraries. Welcome to SVG.
hhh, I agree with that. But I do think it has a hack way to workaround with BackgroundImage / BackgroundAlpha, just a bit complicated to give it a try in satori
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
Passed
0 
0 
0 
0
Close #493
Here I just use inline style just like
filterinsatorito reduce result size and rely on the powerfulresvg. It needs to upgrade@resvg/resvg-jsto2.4.1to supportmix-blend-mode. However, it casues two tests fail which were okay before.You can track them here:
yisibl/resvg-js#256
yisibl/resvg-js#257
After @yisibl and @RazrFalcon checked and resolved them. I think we can merge this PR.