Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #410
Alternative solution considered
NODE_GYP_BUILD
to account for problem identified in Add support for@datadog/pprof
#410. This proved to be tricky as we need to retrieve the value fromfindBindings
which involves a walk of the whole treeSolution
Instead of the alternative above, chose to just add a special case for this package
Automated tests
Just added a conditional
testName === '@datadog-pprof'
to thefoundMatchingBinary
statement so we test the presence of theprebuilds
folder.Manual tests (since the automated tests do not test for presence of
prebuilds
folderRunning
node out/cli.js print node_modules/@datadog/pprof/out/src/index.js
gives me the following FILELISTWe see that the entire
prebuilds
folder is correctly included.