Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for @datadog/pprof #410

Closed
austinwoon opened this issue Apr 18, 2024 · 2 comments · Fixed by #419
Closed

Add support for @datadog/pprof #410

austinwoon opened this issue Apr 18, 2024 · 2 comments · Fixed by #419

Comments

@austinwoon
Copy link

austinwoon commented Apr 18, 2024

When building with output: standalone, @datadog/pprof prebuilds gets excluded as the current AST logic introduced in #391 does not handle the case where imports are assigned to a const.

See @datadog/pprof codebase here on how they assign the CJS import of node-gyp-build to a variable, that way we cannot resolve the name to node-gyp-build just by inferring the AST node's first argument

Suggested solution

Instead of modifying the conditionals to handle this case like in #391, just add a special case for @datadog/pprof to include the prebuilds folder. I have a fix up and will discuss the alternative in more detail here

@ragingwind
Copy link

Is there any progress at all? We have same issue

@austinwoon
Copy link
Author

Is there any progress at all? We have same issue

The PR is up awaiting review. You could comment there just to nudge it towards getting merged

styfle added a commit that referenced this issue May 16, 2024
- Fixes #410
- Closes #411

Note, this is easiest to review without whitespace
https://github.com/vercel/nft/pull/419/files?w=1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants