correctly rethrow instrumentation loading error #65251
Open
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we can't assume the thrown error will have a settable message property
if we do, we end up with an entirely different error thrown
Failed to prepare server TypeError: Cannot set property message of [object Object] which has only a getter
at NextNodeServer.prepareImpl
iscekic
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
AbhiShake1
suggested changes
May 2, 2024
|
@AbhiShake1 I don't have the time to get the test suite running locally right now - I did improve the line however, using the mdn-blessed way of rethrowing errors. |
AbhiShake1
approved these changes
May 2, 2024
That should make it better. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can't assume the thrown error will have a settable message property
if we do, we end up with an entirely different error thrown