New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logging method for warn() to use console.log #65221
base: canary
Are you sure you want to change the base?
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Failing test suitesCommit: 7cc9a5a
Expand output● Custom _error › development mode 2 › should warn on custom /_error without custom /404
Read more about building and testing Next.js in contributing.md.
Expand output● with contentDispositionType attachment › dev support with next.config.js › should maintain animated gif
● with contentDispositionType attachment › dev support with next.config.js › should maintain animated png
● with contentDispositionType attachment › dev support with next.config.js › should maintain animated png 2
● with contentDispositionType attachment › dev support with next.config.js › should maintain animated webp
Read more about building and testing Next.js in contributing.md.
Expand output● Export with getInitialProps › production mode › should show warning with next export
Read more about building and testing Next.js in contributing.md.
Expand output● with minimumCacheTTL of 5 sec › dev support with next.config.js › should maintain animated gif
● with minimumCacheTTL of 5 sec › dev support with next.config.js › should maintain animated png
● with minimumCacheTTL of 5 sec › dev support with next.config.js › should maintain animated png 2
● with minimumCacheTTL of 5 sec › dev support with next.config.js › should maintain animated webp
Read more about building and testing Next.js in contributing.md.
Expand output● CLI Usage › dev › Allow retry if default port is already in use
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir edge SSR › should warn about the re-export of a pages runtime/preferredRegion config
Read more about building and testing Next.js in contributing.md.
Expand output● Build warnings › production mode › should shown warning about minification for minimize
● Build warnings › production mode › should shown warning about minification for minimizer
Read more about building and testing Next.js in contributing.md.
Expand output● Non-Standard NODE_ENV › production mode › should show the warning with NODE_ENV set to development with next build
● Non-Standard NODE_ENV › production mode › should show the warning with NODE_ENV set to development with next start
● Non-Standard NODE_ENV › should show the warning with NODE_ENV set to invalid value
● Non-Standard NODE_ENV › should show the warning with NODE_ENV set to invalid value (custom server)
● Non-Standard NODE_ENV › should show the warning with NODE_ENV set to production with next dev
Read more about building and testing Next.js in contributing.md.
Expand output● config-output-export › when hasNextSupport = false › should error with "rewrites" config
● config-output-export › when hasNextSupport = false › should error with "redirects" config
● config-output-export › when hasNextSupport = false › should error with "headers" config
Read more about building and testing Next.js in contributing.md.
Expand output● Config Experimental Warning › production mode › should show unrecognized experimental features in warning but not in start log experiments section
Read more about building and testing Next.js in contributing.md.
Expand output● required server files › should warn when "next" is imported directly
Read more about building and testing Next.js in contributing.md.
Expand output● Exported runtimes value validation › warns on unrecognized runtimes value
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | pacocoursey/next.js paco/warn-log-method | Change | |
---|---|---|---|
buildDuration | 21.4s | 19.6s | N/A |
buildDurationCached | 10.5s | 9.7s | N/A |
nodeModulesSize | 360 MB | 360 MB | |
nextStartRea..uration (ms) | 488ms | 505ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | pacocoursey/next.js paco/warn-log-method | Change | |
---|---|---|---|
1103-HASH.js gzip | 31.9 kB | 31.9 kB | N/A |
1a9f679d-HASH.js gzip | 53.5 kB | 53.5 kB | N/A |
335-HASH.js gzip | 5.09 kB | 5.09 kB | N/A |
7953.HASH.js gzip | 169 B | 169 B | ✓ |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 230 B | 229 B | N/A |
main-HASH.js gzip | 31.5 kB | 31.5 kB | N/A |
webpack-HASH.js gzip | 1.65 kB | 1.65 kB | N/A |
Overall change | 45.4 kB | 45.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | pacocoursey/next.js paco/warn-log-method | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | pacocoursey/next.js paco/warn-log-method | Change | |
---|---|---|---|
_app-HASH.js gzip | 192 B | 193 B | N/A |
_error-HASH.js gzip | 192 B | 193 B | N/A |
amp-HASH.js gzip | 507 B | 511 B | N/A |
css-HASH.js gzip | 341 B | 343 B | N/A |
dynamic-HASH.js gzip | 2.52 kB | 2.52 kB | ✓ |
edge-ssr-HASH.js gzip | 266 B | 265 B | N/A |
head-HASH.js gzip | 362 B | 365 B | N/A |
hooks-HASH.js gzip | 392 B | 392 B | ✓ |
image-HASH.js gzip | 4.32 kB | 4.32 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.69 kB | 2.7 kB | N/A |
routerDirect..HASH.js gzip | 329 B | 328 B | N/A |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 324 B | 324 B | ✓ |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 4 kB | 4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | pacocoursey/next.js paco/warn-log-method | Change | |
---|---|---|---|
_buildManifest.js gzip | 483 B | 484 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | pacocoursey/next.js paco/warn-log-method | Change | |
---|---|---|---|
index.html gzip | 526 B | 529 B | N/A |
link.html gzip | 540 B | 540 B | ✓ |
withRouter.html gzip | 523 B | 522 B | N/A |
Overall change | 540 B | 540 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | pacocoursey/next.js paco/warn-log-method | Change | |
---|---|---|---|
edge-ssr.js gzip | 94.7 kB | 94.7 kB | N/A |
page.js gzip | 181 kB | 181 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | pacocoursey/next.js paco/warn-log-method | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 621 B | 624 B | N/A |
middleware-r..fest.js gzip | 156 B | 156 B | ✓ |
middleware.js gzip | 25.7 kB | 25.7 kB | N/A |
edge-runtime..pack.js gzip | 839 B | 839 B | ✓ |
Overall change | 995 B | 995 B | ✓ |
Next Runtimes
vercel/next.js canary | pacocoursey/next.js paco/warn-log-method | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 171 kB | 171 kB | ✓ |
app-page-exp..prod.js gzip | 98.5 kB | 98.5 kB | ✓ |
app-page-tur..prod.js gzip | 100 kB | 100 kB | ✓ |
app-page-tur..prod.js gzip | 94.4 kB | 94.4 kB | N/A |
app-page.run...dev.js gzip | 157 kB | 157 kB | N/A |
app-page.run..prod.js gzip | 93.1 kB | 93.1 kB | ✓ |
app-route-ex...dev.js gzip | 21.5 kB | 21.5 kB | N/A |
app-route-ex..prod.js gzip | 15.2 kB | 15.2 kB | ✓ |
app-route-tu..prod.js gzip | 15.2 kB | 15.2 kB | ✓ |
app-route-tu..prod.js gzip | 15 kB | 15 kB | ✓ |
app-route.ru...dev.js gzip | 21.3 kB | 21.3 kB | N/A |
app-route.ru..prod.js gzip | 15 kB | 15 kB | ✓ |
pages-api-tu..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
pages-api.ru...dev.js gzip | 9.82 kB | 9.82 kB | ✓ |
pages-api.ru..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
pages-turbo...prod.js gzip | 21.5 kB | 21.5 kB | ✓ |
pages.runtim...dev.js gzip | 22.1 kB | 22.1 kB | ✓ |
pages.runtim..prod.js gzip | 21.5 kB | 21.5 kB | ✓ |
server.runti..prod.js gzip | 51.6 kB | 51.6 kB | N/A |
Overall change | 617 kB | 617 kB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | pacocoursey/next.js paco/warn-log-method | Change | |
---|---|---|---|
0.pack gzip | 1.62 MB | 1.62 MB | |
index.pack gzip | 114 kB | 113 kB | N/A |
Overall change | 1.62 MB | 1.62 MB |
Diff details
Diff for edge-ssr.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
Diff too large to display
Diff for app-page-exp..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page.runtime.dev.js
Diff too large to display
Diff for app-page.runtime.prod.js
Diff too large to display
Diff for app-route-ex..ntime.dev.js
Diff too large to display
Diff for app-route-ex..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route.runtime.dev.js
Diff too large to display
Diff for app-route.ru..time.prod.js
Diff too large to display
Diff for pages-turbo...time.prod.js
Diff too large to display
Diff for pages.runtime.dev.js
Diff too large to display
Diff for pages.runtime.prod.js
Diff too large to display
Diff for server.runtime.prod.js
Diff too large to display
Code comment is explanatory. On Node.js environments, any warnings (for example, warning about experimental features being used in
next.config.js
) will be considered errors, which can spam logs inaccurately.