Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update swc_core to v0.91.2 #65181

Closed
wants to merge 5 commits into from
Closed

build: Update swc_core to v0.91.2 #65181

wants to merge 5 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 30, 2024

What?

Update SWC crates

Why?

To apply styled-jsx fixes

How?

@kdy1 kdy1 self-assigned this Apr 30, 2024
@kdy1 kdy1 requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners April 30, 2024 01:28
@ijjk ijjk added created-by: Turbopack team PRs by the turbopack team Turbopack Related to Turbopack with Next.js. type: next labels Apr 30, 2024
@kdy1 kdy1 marked this pull request as draft April 30, 2024 05:52
@ijjk
Copy link
Member

ijjk commented Apr 30, 2024

Failing test suites

Commit: 02f341e

pnpm test test/unit/next-swc.test.ts

  • next/swc > hook_optimizer > should leave alone array destructuring of hooks
  • next/swc > hook_optimizer > should leave alone array spread of hooks
Expand output

● next/swc › hook_optimizer › should leave alone array destructuring of hooks

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `next/swc hook_optimizer should leave alone array destructuring of hooks 1`

- Snapshot  - 1
+ Received  + 1

@@ -42,8 +42,8 @@
      var n = Object.prototype.toString.call(o).slice(8, -1);
      if (n === "Object" && o.constructor) n = o.constructor.name;
      if (n === "Map" || n === "Set") return Array.from(n);
      if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _array_like_to_array(o, minLen);
  }
- import { useState } from "react";
+ import { useState } from 'react';
  var _useState = _sliced_to_array(useState(0), 2), count = _useState[0], setCount = _useState[1];
  "

  21 |       )
  22 |
> 23 |       expect(output).toMatchInlineSnapshot(`
     |                      ^
  24 |         "function _array_like_to_array(arr, len) {
  25 |             if (len == null || len > arr.length) len = arr.length;
  26 |             for(var i = 0, arr2 = new Array(len); i < len; i++)arr2[i] = arr[i];

  at Object.toMatchInlineSnapshot (unit/next-swc.test.ts:23:22)

● next/swc › hook_optimizer › should leave alone array spread of hooks

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `next/swc hook_optimizer should leave alone array spread of hooks 1`

- Snapshot  - 1
+ Received  + 1

@@ -21,8 +21,8 @@
      var n = Object.prototype.toString.call(o).slice(8, -1);
      if (n === "Object" && o.constructor) n = o.constructor.name;
      if (n === "Map" || n === "Set") return Array.from(n);
      if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _array_like_to_array(o, minLen);
  }
- import { useState } from "react";
+ import { useState } from 'react';
  var _useState = _to_array(useState(0)), copy = _useState.slice(0);
  "

  82 |       )
  83 |
> 84 |       expect(output).toMatchInlineSnapshot(`
     |                      ^
  85 |         "function _array_like_to_array(arr, len) {
  86 |             if (len == null || len > arr.length) len = arr.length;
  87 |             for(var i = 0, arr2 = new Array(len); i < len; i++)arr2[i] = arr[i];

  at Object.toMatchInlineSnapshot (unit/next-swc.test.ts:84:22)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Apr 30, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/swc-core-0-91-1 Change
buildDuration 19.6s 18s N/A
buildDurationCached 10s 9.4s N/A
nodeModulesSize 360 MB 360 MB N/A
nextStartRea..uration (ms) 468ms 463ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/swc-core-0-91-1 Change
1103-HASH.js gzip 31.9 kB 31.9 kB N/A
1a9f679d-HASH.js gzip 53.5 kB 53.5 kB N/A
335-HASH.js gzip 5.09 kB 5.09 kB N/A
7953.HASH.js gzip 169 B 169 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 231 B 229 B N/A
main-HASH.js gzip 31.5 kB 31.5 kB N/A
webpack-HASH.js gzip 1.65 kB 1.65 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/swc-core-0-91-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/swc-core-0-91-1 Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 193 B N/A
amp-HASH.js gzip 507 B 511 B N/A
css-HASH.js gzip 341 B 343 B N/A
dynamic-HASH.js gzip 2.52 kB 2.52 kB
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 362 B 365 B N/A
hooks-HASH.js gzip 392 B 392 B
image-HASH.js gzip 4.32 kB 4.32 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.7 kB N/A
routerDirect..HASH.js gzip 329 B 328 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 324 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 4 kB 4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/swc-core-0-91-1 Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/swc-core-0-91-1 Change
index.html gzip 527 B 527 B
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 527 B 527 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/swc-core-0-91-1 Change
edge-ssr.js gzip 94.7 kB 94.7 kB N/A
page.js gzip 181 kB 181 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/swc-core-0-91-1 Change
middleware-b..fest.js gzip 622 B 625 B N/A
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.7 kB 25.7 kB
edge-runtime..pack.js gzip 839 B 839 B
Overall change 26.7 kB 26.7 kB
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/swc-core-0-91-1 Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 100 kB 100 kB
app-page-tur..prod.js gzip 94.3 kB 94.3 kB
app-page.run...dev.js gzip 157 kB 157 kB
app-page.run..prod.js gzip 93.1 kB 93.1 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route.ru...dev.js gzip 21.3 kB 21.3 kB
app-route.ru..prod.js gzip 15 kB 15 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 51.6 kB 51.6 kB
Overall change 962 kB 962 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/swc-core-0-91-1 Change
0.pack gzip 1.62 MB 1.62 MB ⚠️ +585 B
index.pack gzip 112 kB 112 kB N/A
Overall change 1.62 MB 1.62 MB ⚠️ +585 B
Diff details
Diff for edge-ssr.js

Diff too large to display

Commit: 02f341e

@kdy1
Copy link
Member Author

kdy1 commented May 7, 2024

Closing as there was a breaking change in swc_core

@kdy1 kdy1 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the turbopack team Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SWC panicks when processing nested styled-jsx tags SWC does not catch nested styled-jsx tags in props
2 participants