Improve app performance and update search bar style #7151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have updated the `positionIsValid()` function to filter out displays the only have intersection with the target point. This improves performance.
…mamnd The `generatePrefixedCommand` is a simple pure function. But it used `map()` for looping over the shortcuts. The `map()` creates a new every time and creates unnecessary memory allocations. I have switched to using the `for..loop`. Another change I made is in the default function for getting keymaps. I have switched from using the method `Object.keys()` which creates a new array and instead used `for..in` loop. I also declared the `keymap` variable outside of the scope to limit the number of times object is modified. Used `for..of` instead of `forEach` because it creates a new function for every iteration.
The utility electron background color converts colors for electron support. I have added a new object which is optimised for frequent reads and updates. This saves processing time and power.
For filtering out undefined properties from the `extraOptions`, `createSession` function used `Object.keys` and looped over to check for undefined keys. Using `object.fromEntries` checks for undefined properties and is also better performant.
haneenmahd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves performance and also adds style update to the search bar. It adds a shadow to create an overlay effect.