Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide better reader matchers #55

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Provide better reader matchers #55

merged 1 commit into from
Oct 30, 2023

Conversation

veewee
Copy link
Owner

@veewee veewee commented Oct 29, 2023 •
edited
Loading

Q A
Type improvement
BC Break no
Deprecations yes
Fixed issues

Summary

Provides better reader matchers:

  • all()
  • any()
  • attribute_local_name()
  • attribute_local_value()
  • attribute_name()
  • attribute_value()
  • document_element()
  • element_local_name()
  • element_name()
  • element_position()
  • namespaced_attribute()
  • namespaced_attribute_value()
  • namespaced_element()
  • not()
  • sequence()

Deprecates:

  • node_attribute()
  • node_name()

@veewee veewee marked this pull request as draft October 29, 2023 14:35
@veewee veewee force-pushed the reader-matchers branch 7 times, most recently from ae90b22 to 33570df Compare October 30, 2023 12:29
@veewee veewee changed the title [WIP] Provide better reader matchers Provide better reader matchers Oct 30, 2023
@veewee veewee marked this pull request as ready for review October 30, 2023 12:30
@veewee veewee added this to the 2.8.0 milestone Oct 30, 2023
@veewee veewee added the enhancement New feature or request label Oct 30, 2023
@veewee veewee merged commit a425c77 into main Oct 30, 2023
20 checks passed
@veewee veewee deleted the reader-matchers branch October 30, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@veewee