Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Ubuntu 22.04 #42

Merged
merged 3 commits into from
May 18, 2024
Merged

Conversation

lucasw
Copy link

@lucasw lucasw commented May 6, 2024

Mostly this was replacing boost::make_shared with std::make_shared when it came to pcl point clouds. Not sure if that is backwards compatible with 20.04.

libpcl-dev                                         1.12.1+dfsg-3build1

@kennyjchen
Copy link
Contributor

Yeah PCL 1.12 has a breaking change where they switch smart pointers. Instead of pushing to master, I made a new branch feature/ubuntu-2204. Can you PR to that instead? Thanks for the contribution.

@lucasw lucasw changed the base branch from master to feature/ubuntu-2204 May 17, 2024 13:46
@kennyjchen kennyjchen merged commit 29c2231 into vectr-ucla:feature/ubuntu-2204 May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants