Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump prettydiff from 0.6.4 to 0.7.0 #20460

Merged
merged 3 commits into from
May 10, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 8, 2024

Bumps prettydiff from 0.6.4 to 0.7.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [prettydiff](https://github.com/romankoblov/prettydiff) from 0.6.4 to 0.7.0.
- [Commits](https://github.com/romankoblov/prettydiff/commits)

---
updated-dependencies:
- dependency-name: prettydiff
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added domain: deps Anything related to Vector's dependencies no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels May 8, 2024
Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko enabled auto-merge May 9, 2024 19:09
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented May 9, 2024

Datadog Report

Branch report: dependabot/cargo/prettydiff-0.7.0
Commit report: 75ddaa5
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.4s Total Time

@jszwedko jszwedko added this pull request to the merge queue May 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 10, 2024
@jszwedko
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github May 10, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@jszwedko jszwedko enabled auto-merge May 10, 2024 15:42
@jszwedko jszwedko force-pushed the dependabot/cargo/prettydiff-0.7.0 branch from 2c9ee68 to fe049be Compare May 10, 2024 15:43
@jszwedko jszwedko added this pull request to the merge queue May 10, 2024
Copy link

Regression Detector Results

Run ID: 39419eda-5b94-49d6-adde-56d888deba28
Baseline: d8922d1
Comparison: 42cff17
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_loki ingress throughput +1.53 [+1.46, +1.59]
otlp_http_to_blackhole ingress throughput +1.29 [+1.14, +1.43]
syslog_splunk_hec_logs ingress throughput +1.05 [+0.97, +1.13]
socket_to_socket_blackhole ingress throughput +0.99 [+0.92, +1.06]
fluent_elasticsearch ingress throughput +0.79 [+0.31, +1.28]
syslog_humio_logs ingress throughput +0.74 [+0.63, +0.84]
otlp_grpc_to_blackhole ingress throughput +0.67 [+0.58, +0.76]
http_elasticsearch ingress throughput +0.59 [+0.52, +0.67]
datadog_agent_remap_datadog_logs ingress throughput +0.59 [+0.48, +0.69]
http_to_http_acks ingress throughput +0.25 [-1.10, +1.60]
splunk_hec_route_s3 ingress throughput +0.19 [-0.27, +0.64]
http_to_http_noack ingress throughput +0.13 [+0.03, +0.22]
http_to_http_json ingress throughput +0.07 [-0.01, +0.15]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
enterprise_http_to_http ingress throughput -0.03 [-0.09, +0.02]
file_to_blackhole egress throughput -0.05 [-2.42, +2.32]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.06 [-0.17, +0.06]
datadog_agent_remap_blackhole_acks ingress throughput -0.10 [-0.21, +0.02]
datadog_agent_remap_datadog_logs_acks ingress throughput -0.29 [-0.38, -0.20]
http_to_s3 ingress throughput -0.49 [-0.77, -0.21]
datadog_agent_remap_blackhole ingress throughput -0.70 [-0.79, -0.61]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.81 [-0.93, -0.68]
syslog_regex_logs2metric_ddmetrics ingress throughput -0.88 [-1.04, -0.73]
syslog_log2metric_splunk_hec_metrics ingress throughput -1.43 [-1.58, -1.29]
http_text_to_http_json ingress throughput -1.83 [-1.96, -1.70]
syslog_log2metric_humio_metrics ingress throughput -2.48 [-2.61, -2.35]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link

Regression Detector Results

Run ID: ea220e8e-2612-4667-9195-52362a5e0b2a
Baseline: 19def61
Comparison: 13aaea1
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole egress throughput +2.20 [-0.41, +4.81]
syslog_log2metric_humio_metrics ingress throughput +2.12 [+1.99, +2.26]
syslog_log2metric_splunk_hec_metrics ingress throughput +1.39 [+1.22, +1.56]
http_to_http_acks ingress throughput +1.21 [-0.15, +2.57]
fluent_elasticsearch ingress throughput +0.77 [+0.28, +1.27]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +0.72 [+0.59, +0.86]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.41 [+0.32, +0.49]
otlp_http_to_blackhole ingress throughput +0.33 [+0.18, +0.47]
datadog_agent_remap_blackhole ingress throughput +0.31 [+0.22, +0.40]
http_to_http_noack ingress throughput +0.08 [-0.02, +0.19]
socket_to_socket_blackhole ingress throughput +0.05 [-0.03, +0.12]
http_to_http_json ingress throughput +0.03 [-0.05, +0.11]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.12, +0.11]
http_elasticsearch ingress throughput -0.01 [-0.08, +0.05]
http_to_s3 ingress throughput -0.03 [-0.31, +0.24]
enterprise_http_to_http ingress throughput -0.10 [-0.18, -0.02]
http_text_to_http_json ingress throughput -0.16 [-0.30, -0.01]
datadog_agent_remap_blackhole_acks ingress throughput -0.17 [-0.27, -0.08]
datadog_agent_remap_datadog_logs ingress throughput -0.52 [-0.63, -0.41]
syslog_humio_logs ingress throughput -0.58 [-0.73, -0.43]
syslog_loki ingress throughput -0.58 [-0.64, -0.52]
splunk_hec_route_s3 ingress throughput -0.59 [-1.04, -0.13]
syslog_regex_logs2metric_ddmetrics ingress throughput -0.82 [-0.94, -0.70]
otlp_grpc_to_blackhole ingress throughput -0.85 [-0.94, -0.76]
syslog_splunk_hec_logs ingress throughput -1.47 [-1.56, -1.37]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 13aaea1 May 10, 2024
50 checks passed
@jszwedko jszwedko deleted the dependabot/cargo/prettydiff-0.7.0 branch May 10, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: deps Anything related to Vector's dependencies no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant