Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Drop cached #20455

Merged
merged 1 commit into from May 9, 2024
Merged

chore(deps): Drop cached #20455

merged 1 commit into from May 9, 2024

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented May 7, 2024

It's listed in vdev but not actually used

It's listed in `vdev` but not actually used
@bruceg bruceg added dependencies Pull requests that update a dependency file no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels May 7, 2024
@bruceg bruceg requested a review from jszwedko May 7, 2024 23:09
@github-actions github-actions bot added the domain: vdev Anything related to the vdev tooling label May 7, 2024
@bruceg bruceg enabled auto-merge May 7, 2024 23:22
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: bruceg/drop-cached
Commit report: 3d0ac2e
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.45s Wall Time

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot.

@bruceg bruceg added this pull request to the merge queue May 8, 2024
@jszwedko jszwedko removed this pull request from the merge queue due to a manual request May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Regression Detector Results

Run ID: ed919844-d298-45f8-9236-06ec9765190e
Baseline: 0da155d
Comparison: 52e4c95
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_log2metric_humio_metrics ingress throughput +3.14 [+3.00, +3.28]
otlp_http_to_blackhole ingress throughput +1.15 [+1.01, +1.29]
datadog_agent_remap_blackhole_acks ingress throughput +0.99 [+0.90, +1.08]
socket_to_socket_blackhole ingress throughput +0.62 [+0.52, +0.72]
otlp_grpc_to_blackhole ingress throughput +0.23 [+0.14, +0.32]
syslog_humio_logs ingress throughput +0.19 [+0.05, +0.33]
http_to_http_noack ingress throughput +0.13 [+0.04, +0.22]
splunk_hec_route_s3 ingress throughput +0.03 [-0.43, +0.48]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14]
http_to_http_json ingress throughput -0.00 [-0.07, +0.07]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
enterprise_http_to_http ingress throughput -0.02 [-0.10, +0.07]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.05 [-0.16, +0.07]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.08 [-0.25, +0.08]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.19 [-0.35, -0.02]
syslog_regex_logs2metric_ddmetrics ingress throughput -0.31 [-0.47, -0.15]
fluent_elasticsearch ingress throughput -0.31 [-0.80, +0.17]
http_to_s3 ingress throughput -0.33 [-0.61, -0.05]
syslog_loki ingress throughput -0.43 [-0.49, -0.37]
datadog_agent_remap_datadog_logs ingress throughput -0.52 [-0.63, -0.41]
http_to_http_acks ingress throughput -0.69 [-2.05, +0.67]
datadog_agent_remap_blackhole ingress throughput -0.75 [-0.88, -0.63]
datadog_agent_remap_datadog_logs_acks ingress throughput -0.89 [-0.98, -0.81]
http_elasticsearch ingress throughput -1.06 [-1.14, -0.99]
http_text_to_http_json ingress throughput -1.36 [-1.49, -1.24]
syslog_splunk_hec_logs ingress throughput -1.68 [-1.77, -1.60]
file_to_blackhole egress throughput -3.01 [-5.44, -0.58]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link

github-actions bot commented May 9, 2024

Regression Detector Results

Run ID: 1b5fe464-12c7-4a5b-847f-ea7cf09101bb
Baseline: 3a115c5
Comparison: 783ed1f
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
http_text_to_http_json ingress throughput +3.57 [+3.41, +3.73]
datadog_agent_remap_datadog_logs_acks ingress throughput +1.86 [+1.77, +1.95]
file_to_blackhole egress throughput +1.35 [-1.12, +3.83]
otlp_http_to_blackhole ingress throughput +1.33 [+1.19, +1.47]
datadog_agent_remap_blackhole_acks ingress throughput +0.91 [+0.82, +1.00]
splunk_hec_route_s3 ingress throughput +0.58 [+0.11, +1.04]
syslog_regex_logs2metric_ddmetrics ingress throughput +0.52 [+0.36, +0.67]
http_to_s3 ingress throughput +0.41 [+0.13, +0.69]
syslog_loki ingress throughput +0.30 [+0.23, +0.37]
http_to_http_noack ingress throughput +0.08 [-0.02, +0.19]
http_to_http_acks ingress throughput +0.06 [-1.30, +1.43]
http_to_http_json ingress throughput +0.03 [-0.04, +0.10]
socket_to_socket_blackhole ingress throughput +0.02 [-0.04, +0.08]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.07 [-0.18, +0.04]
enterprise_http_to_http ingress throughput -0.12 [-0.20, -0.04]
syslog_humio_logs ingress throughput -0.21 [-0.34, -0.08]
http_elasticsearch ingress throughput -0.42 [-0.49, -0.35]
syslog_log2metric_humio_metrics ingress throughput -0.60 [-0.70, -0.50]
otlp_grpc_to_blackhole ingress throughput -0.65 [-0.74, -0.56]
datadog_agent_remap_blackhole ingress throughput -0.84 [-0.95, -0.73]
datadog_agent_remap_datadog_logs ingress throughput -1.38 [-1.49, -1.26]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -1.41 [-1.56, -1.26]
syslog_splunk_hec_logs ingress throughput -1.44 [-1.54, -1.34]
fluent_elasticsearch ingress throughput -1.82 [-2.31, -1.34]
syslog_log2metric_splunk_hec_metrics ingress throughput -2.24 [-2.41, -2.07]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 783ed1f May 9, 2024
57 checks passed
@jszwedko jszwedko deleted the bruceg/drop-cached branch May 9, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants