chore(core): Add helper function to add a semantic meaning to an event metadata #20439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruceg
added
domain: schemas
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.38s Wall Time |
|
As a side note, this article about unwind describes why we can't just replace the schema slot in the metadata and have to resort to the uninit data shenanigans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the pattern referenced in the comments while reviewing some new code, and wanted to add a helper to simplify using that pattern in future code. While doing so, I realized that, since the field may be immediately replaced by the same value, we could play games with unwrapping the
Arcinstead of cloning it to improve efficiency.