enhancement(aws s3 and azure blob sinks) Emit a counter for when aws s3 and azure blob storage requests are made #20400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: sinks
flavioc
changed the title
jszwedko
reviewed
May 3, 2024
There was a problem hiding this comment.
Hi @flavioc !
Thanks for opening this. We actually already have a metric for HTTP requests, https://vector.dev/docs/reference/configuration/sources/internal_metrics/#http_client_requests_sent_total. Though, maybe it isn't being correctly published by the blob storage sinks. Did you attempt to use that metric already? I know it won't have the same tags you have here so maybe would be insufficient.
flavioc
force-pushed
the
publish-azure-aws-events
branch
from
b6c40da
to
024ca1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are exposing two new metrics to track requests into AWS S3 and Azure Blob Storage: