enhancement(kafka sink): Make healthcheck topic configurable #20373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
domain: sinks
|
Please let me know if the proposed approach makes sense or if you have other suggestions! This is also my first time contributing and writing Rust code, so any feedback would be appreciated! |
estherk15
approved these changes
Apr 26, 2024
jszwedko
approved these changes
May 3, 2024
There was a problem hiding this comment.
Thanks for this @yalinglee ! I think ideally this option would live under the existing healthcheck option (e.g. as healthcheck.topic but I recognize that that would be a fairly large refactoring of the config structs and, likely, the documentation so I'm ok with having this be a top-level option for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a solution for #10465.
It adds a new
healthcheck_topicoption so when thetopicvalue is templated, healthchecks won't fail.Closes: #10465