fix(vector): Fix indentation for haproxy.initContainers #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects the indentation for optional HAProxy init-containers by trimming initial whitespaces from the template.
Jonher937
approved these changes
May 17, 2024
hamps-contrib
approved these changes
May 17, 2024
jszwedko
reviewed
May 20, 2024
There was a problem hiding this comment.
Thanks @ludwighansson ! I think this PR may just need the chart version bumped and helm-docs rerun. I kicked off CI which should tell us.
jszwedko
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello friends!
I just encountered a small issue with the
vectorchart when trying to add an optional init-container for the HAProxy deployment. The line that expands.Values.haproxy.initContainersdoesn't trim the initial whitespaces, causing the first line of the rendered YAML to have 16 spaces instead of the desired 8.Added a
{{-to trim the initial whitespaces (and newline), and usednindentto add the newline again. This aligns with other expansions within this template :)This is my first PR, so please let me know if you need any additional info or if I need to change the commit message etc. Tried to keep it similar to the existing ones ;)
Cheers!