[WIP] Update timestamp if exists #2174
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
76c4e58
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2955e855.vald.pages.dev |
| Branch Preview URL: | https://feature-timestamp-update-tim.vald.pages.dev |
github-actions
bot
added
team/set
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
kevindiu
force-pushed
the
feature/timestamp/update-timestamp-when-update-upsert
branch
2 times, most recently
from
95d8330
to
82db537
Compare
kevindiu
force-pushed
the
feature/timestamp/update-timestamp-when-update-upsert
branch
2 times, most recently
from
9ec458e
to
3c9dd08
Compare
| @@ -832,6 +837,208 @@ func Test_server_Update(t *testing.T) { | |||
| wantUUID: "uuid-2", | |||
| }, | |||
| }, | |||
| func() test { | |||
| indexID := "test" | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
string test has 4 occurrences, make it a constant (goconst)
kevindiu
force-pushed
the
feature/timestamp/update-timestamp-when-update-upsert
branch
from
0b1786d
to
4ff11e2
Compare
| @@ -832,6 +842,423 @@ func Test_server_Update(t *testing.T) { | |||
| wantUUID: "uuid-2", | |||
| }, | |||
| }, | |||
| func() test { | |||
| indexID := "test" | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
string test has 8 occurrences, make it a constant (goconst)
| @@ -832,6 +846,549 @@ func Test_server_Update(t *testing.T) { | |||
| wantUUID: "uuid-2", | |||
| }, | |||
| }, | |||
| func() test { | |||
| indexID := "test" | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
string test has 12 occurrences, make it a constant (goconst)
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
kevindiu
force-pushed
the
feature/timestamp/update-timestamp-when-update-upsert
branch
from
253d353
to
cc58f89
Compare
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: