CWindowWithArtifacts refactoring part2 #3895
Conversation
SoundSSGood
force-pushed
the
CWindowWithArtifacts-refactoring2
branch
5 times, most recently
from
42dca77
to
2079281
Compare
|
why was shift + click idea abandoned? it would be good feature in addition to having this at mouse wheel |
There is no way to close the window without swapping artifact. |
|
there is backpack button at the bottom of hero window - maybe that variant of backpack could be reused in this case? |
|
Maybe yes. I'll deal with this a little later |
SoundSSGood
force-pushed
the
CWindowWithArtifacts-refactoring2
branch
3 times, most recently
from
f93caaa
to
df91317
Compare
| using ArtifactsOfHeroVar = std::variant< | ||
| std::shared_ptr<CArtifactsOfHeroMarket>, | ||
| std::shared_ptr<CArtifactsOfHeroAltar>, | ||
| std::shared_ptr<CArtifactsOfHeroKingdom>, | ||
| std::shared_ptr<CArtifactsOfHeroMain>, | ||
| std::shared_ptr<CArtifactsOfHeroBackpack>, | ||
| std::shared_ptr<CArtifactsOfHeroQuickBackpack>>; |
There was a problem hiding this comment.
I know that this is not a new code, but why you opted to use variant here instead of using interface with different implementations with virtual methods?
There was a problem hiding this comment.
At a certain stage of working with the code, it was easier to distinguish which window we were working with at the moment. But for now, you may be right. Switching to virtual methods may make the code even simpler.
There was a problem hiding this comment.
I'll try to redo it
SoundSSGood
force-pushed
the
CWindowWithArtifacts-refactoring2
branch
4 times, most recently
from
5e0bb36
to
a5ca274
Compare
SoundSSGood
force-pushed
the
CWindowWithArtifacts-refactoring2
branch
from
a5ca274
to
3692ca2
Compare
Shift+click on the artifact slot should open the quick backpack window.