Add clang-format configuration #1585
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IvanSavenko please, consider this differences: |
|
@rilian-la-te |
|
@rilian-la-te
|
|
About 'BreakConstructorInitializersBeforeComma' - for new clang-format it is deprecated and replaced by BreakConstructorInitializers. I strongly prefer AfterColon style, it just looks more natural for me. |
|
About SplitEmptyFunction - it seems than old code uses True. |
|
my personal preferences on the differences: AllowShortFunctionsOnASingleLine: Empty BreakBeforeInheritanceComma: no idea as not in docs. Based on the name it's about class A : public B, public C {};
// for consistency we may use same as BreakConstructorInitializers
class A : public B
, public C
{
};
// or even
class A
: public B
, public C
{
};but at the same time multiple inheritance is a rather rare thing (and adding new parent is even rarer) and would be fine to just have all parents on a single line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at clang-format, slightly improved & corrected version compared to previous PR.
It is still not perfect, but I've been using it recently with quite good results. So proposing to add it to our repo and use it as guideline for formatting.
I do not think that clang-format is good enough for automatic usage, e.g. in that git+clang-format tool but only as a base guideline. Meaning, code still needs basic readability pass by a developer, however with clang-format you can forget about "basic" stuff like spacing.
Example of such usage is my PR #1581, for example these two files:
https://github.com/IvanSavenko/vcmi/blob/map_render_rewrite/client/adventureMap/MapRenderer.cpp
https://github.com/IvanSavenko/vcmi/blob/map_render_rewrite/client/adventureMap/MapRenderer.h
I think at this point we can add it to repo, let everyone else try it and do any further changes based on everyone's opinion.